Skip to content

Conversation

@tgodzik
Copy link

@tgodzik tgodzik commented Oct 28, 2025

Backports scala#20459 to the 3.3.7.

PR submitted by the release tooling.

Emil Ejbyfeldt and others added 3 commits October 28, 2025 12:43
This fixes scala#15692 and does not seem to break an existing compilation
tests. The problem with seen when it comes scala#15692 is that seen means
that type that has repeated types will get a lower size and this
incorrectly triggers the divergence check since some of the steps
involved less repeated types.

The seen logic was introduced in scala#6329 and the motivation was to deal
with F-bounds. Since not tests fail it not clear if this logic is still
needed to deal with F-bounds? If it is still needed we can add a test
and instead of removing the seen logic we can make it track only types
the appear as a bound and could cause infinite recursion instead of
tracking all.

[Cherry-picked c2ef180]
Also adds test case that stackoverflows without any seen check.

[Cherry-picked 008d58e]
@tgodzik tgodzik force-pushed the backport-lts-3.3-20459 branch from 30183c6 to 84b3f1e Compare October 28, 2025 13:07
This got introduced, because we no longer check in Scala Next. I added an additional check in metals to make sure this doesn't happen anymore.
@tgodzik
Copy link
Author

tgodzik commented Oct 30, 2025

Regression present in this PR:

Base automatically changed from backport-lts-3.3-23792 to lts-3.3 October 31, 2025 10:26
@tgodzik
Copy link
Author

tgodzik commented Oct 31, 2025

No regressions detected in the community build up to backport-lts-3.3-20459.

Reference

@tgodzik tgodzik merged commit 068bf4e into lts-3.3 Oct 31, 2025
22 checks passed
@tgodzik tgodzik deleted the backport-lts-3.3-20459 branch October 31, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants